Fix some Codacy warnings about redundant assignment #3873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcelRaad
changed the title
|
The "new" Codacy warning is just from moved code. |
jay
reviewed
May 13, 2019
lib/ssh-libssh.c
Outdated
| curl_socket_t sock = conn->sock[FIRSTSOCKET]; | ||
| curl_socket_t fd_read = CURL_SOCKET_BAD; | ||
| fd_read = sock; | ||
| curl_socket_t fd_read = conn->sock[FIRSTSOCKET; |
MarcelRaad
force-pushed
the
codacy_redundantassignment
branch
from
199c55a
to
2670274
Compare
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
May 13, 2019
sock was only used to be assigned to fd_read. Closes curl#3873
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
May 13, 2019
This way, we need only one call to free. Closes curl#3873
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
May 13, 2019
Just initialize word_begin with the correct value. Closes curl#3873
MarcelRaad
force-pushed
the
codacy_redundantassignment
branch
from
2670274
to
c57b8a2
Compare
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
May 20, 2019
This way, we need only one call to free. Closes curl#3873
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
May 20, 2019
Just initialize word_begin with the correct value. Closes curl#3873
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a useless variable, narrow a variable scope, and initialize a variable with the correct value to fix them.