nss: allow to specify TLS 1.3 ciphers if supported by NSS #3916
Conversation
| @@ -216,6 +216,11 @@ static const cipher_s cipherlist[] = { | |||
| {"dhe_rsa_chacha20_poly1305_sha_256", | |||
| TLS_DHE_RSA_WITH_CHACHA20_POLY1305_SHA256}, | |||
| #endif | |||
| #ifdef TLS_AES_256_GCM_SHA384 | |||
There was a problem hiding this comment.
How did you come up with this as opposed to TLS_CHACHA20_POLY1305_SHA256? In other words if TLS_AES_256_GCM_SHA384 is defined then TLS_CHACHA20_POLY1305_SHA256 is definitely defined?
There was a problem hiding this comment.
How did you come up with this as opposed to TLS_CHACHA20_POLY1305_SHA256?
I did not, @tomato42 did.
In other words if
TLS_AES_256_GCM_SHA384is defined thenTLS_CHACHA20_POLY1305_SHA256is definitely defined?
I think so. All the defines were introduced in a single commit:
nss-dev/nss@e272467e#diff-61a352311f838d5a89d178abc1f4bb6aR207
There was a problem hiding this comment.
Ok. Please add them to the NSS section of CIPHERS.md. Are they set using CURLOPT_TLS13_CIPHERS? OpenSSL CIPHERS has a separate section for TLS 1.3 ciphers, is something similar is needed for NSS?
There was a problem hiding this comment.
OpenSSL uses separate API for setting TLS 1.3 ciphers, NSS doesn't
|
Thanks for review! Merging... |
No description provided.