Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config-win32.h: HAVE_GETSOCKNAME #3923

Closed
wants to merge 5 commits into from
Closed

Update config-win32.h: HAVE_GETSOCKNAME #3923

wants to merge 5 commits into from

Conversation

Zenju
Copy link
Contributor

@Zenju Zenju commented May 22, 2019

Hi,

just compiled 7.65 on Windows and noticed:

libcurl\lib\connect.c(734,38): warning C4101: 'ssloc': unreferenced local variable

Turns out HAVE_GETPEERNAME is not defined in config-win32.h, but it seems this is by accident?

bagder
bagder approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bagder bagder added build Windows Windows-specific labels May 22, 2019
@bagder
Copy link
Member

bagder commented May 22, 2019

BTW, we can and should also define HAVE_IF_NAMETOINDEX while at it, right?

@Zenju
Copy link
Contributor Author

Zenju commented May 22, 2019

BTW, we can and should also define HAVE_IF_NAMETOINDEX while at it, right?

Sounds good. if_nametoindex() requires Vista and later, so I moved the "COMPILER SPECIFIC" part up a bit in order to test for the build target.

@Zenju
Copy link
Contributor Author

Zenju commented May 22, 2019 •
edited

While at it, maybe also add:

#if defined(HAVE_ZLIB_H)
#define HAVE_LIBZ 1
#endif

? At least on Windows you currently have to manually define both macros to use zlib.

@MarcelRaad
Copy link
Member

Sorry, that doesn't look quite right now. Iphlpapi.h availability is independent of the target Windows version, only the individual functions aren't.

@bagder bagder requested a review from MarcelRaad May 23, 2019 07:23
@MarcelRaad MarcelRaad self-assigned this May 23, 2019
@MarcelRaad
Copy link
Member

Thanks! Squashed and edited slightly to reduce the diff size.

@MarcelRaad MarcelRaad mentioned this pull request May 23, 2019
Closed
bagder referenced this pull request May 23, 2019
@bagder
libcurl: #ifdef away more code for disabled features/protocols
e91e481
@lock lock bot locked as resolved and limited conversation to collaborators Aug 21, 2019
@Zenju Zenju deleted the patch-3 branch November 7, 2022 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

@MarcelRaad MarcelRaad Awaiting requested review from MarcelRaad

Assignees

@MarcelRaad MarcelRaad

Labels
build Windows Windows-specific
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zenju @bagder @MarcelRaad