Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conncache: Remove the DEBUGASSERT on length check #3962

Closed
wants to merge 1 commit into from

Conversation

captain-caveman2k
Copy link
Contributor

We trust the calling code as this is an internal function.

@bagder
Copy link
Member

bagder commented May 29, 2019

If we remove this, then I think the '128' value used for the buffer in two places should be changed to a define like HASKEY_SIZE instead to make it more obvious it's not a choice to use whatever value you like.

We trust the calling code as this is an internal function.
@captain-caveman2k captain-caveman2k changed the title conncache: Remove DEBUGASSET on length check conncache: Remove DEBUGASSERT on length check May 29, 2019
@captain-caveman2k captain-caveman2k changed the title conncache: Remove DEBUGASSERT on length check conncache: Remove the DEBUGASSERT on length check May 29, 2019
@captain-caveman2k captain-caveman2k deleted the seg_fault.1 branch May 31, 2019 11:43
@lock lock bot locked as resolved and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants