Fix more Codacy warnings #3975
Closed
Fix more Codacy warnings #3975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
approved these changes
Jun 2, 2019
lib/ftp.c
Outdated
| /* We've sent the TYPE, now we must send the list of prequote strings */ | ||
|
|
||
| result = ftp_state_quote(conn, TRUE, FTP_RETR_PREQUOTE); | ||
| CURLcode result = ftp_state_quote(conn, TRUE, FTP_RETR_PREQUOTE); |
There was a problem hiding this comment.
This could even do a return straight away without storing the return code in a variable...
lib/ftp.c
Outdated
| /* We've sent the TYPE, now we must send the list of prequote strings */ | ||
|
|
||
| result = ftp_state_quote(conn, TRUE, FTP_STOR_PREQUOTE); | ||
| CURLcode result = ftp_state_quote(conn, TRUE, FTP_STOR_PREQUOTE); |
packages/OS400/os400sys.c
Outdated
| char * enodename; | ||
| char * eservname; | ||
| char * enodename = (char *)NULL; | ||
| char * eservname = (char *)NULL; |
There was a problem hiding this comment.
this could also fix the code style: make it char *ennodename (without the extra space after the asterisk)
There was a problem hiding this comment.
Is this (char *) cast required for Codacy as we have char *variable = NULL elsewhere?
There was a problem hiding this comment.
@captain-caveman2k No it's not, I just moved the whole expression from below. I'll remove the cast.
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Jun 2, 2019
Reduce variable scopes and remove redundant variable stores. Closes curl#3975
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Jun 2, 2019
As want is size_t, (file->buffer_pos - want) is unsigned, so checking if it's less than zero makes no sense. Check if file->buffer_pos is less than want instead to avoid the unsigned integer wraparound. Closes curl#3975
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Jun 2, 2019
Compilers and static analyzers warn about using C-style casts here. Closes curl#3975
Reduce variable scopes and remove redundant variable stores. Closes curl#3975
As want is size_t, (file->buffer_pos - want) is unsigned, so checking if it's less than zero makes no sense. Check if file->buffer_pos is less than want instead to avoid the unsigned integer wraparound. Closes curl#3975
Compilers and static analyzers warn about using C-style casts here. Closes curl#3975
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Jun 5, 2019
Reduce variable scopes and remove redundant variable stores. Closes curl#3975
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Jun 5, 2019
As want is size_t, (file->buffer_pos - want) is unsigned, so checking if it's less than zero makes no sense. Check if file->buffer_pos is less than want instead to avoid the unsigned integer wraparound. Closes curl#3975
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Jun 5, 2019
Compilers and static analyzers warn about using C-style casts here. Closes curl#3975
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the "code style" C warnings in Codacy down to 57, most of which are either false positives or dead stores with the variable overriden after being initialized to a default value.
I'm not going to merge this before the 7.65.1 release. Just opening the PR because I had already forgotten about that branch.