Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Windows SSL support for CMake build #399

Closed
wants to merge 1 commit into from
Closed

added Windows SSL support for CMake build #399

wants to merge 1 commit into from

Conversation

snikulov
Copy link
Member

Re-enabled Windows SSL support for CMake build.

Tested with MSVC 2013/2015, MinGW 5.1.0.

c:\WORK\GitHub\curl\mingw\src>curl --version
curl 7.45.0-DEV (Windows) libcurl/7.45.0-DEV WinSSL
Protocols: dict file ftp ftps gopher http https imap imaps pop3 pop3s rtsp smtp smtps telnet tftp
Features: SSPI Kerberos SPNEGO NTLM SSL

@snikulov
Copy link
Member Author

@bradking Could you please review and comment? Thank you.

@bradking
Copy link
Contributor

Good start. If HAVE_SCHANNEL_H succeeds but HAVE_SSPI_H fails then one will get compilation errors with the current logic. We cannot allow the configured header to define USE_SCHANNEL but not USE_WINDOWS_SSPI. Please update the logic accordingly.

Style nit: the CMakeLists.txt file currently uses 2-space indentation but the patch adds a block using 4-space indentation.

@snikulov
Copy link
Member Author

@bradking fixed both comments 5d1581c4b89b8b334de9dad5883e91ef57d88441

@bradking
Copy link
Contributor

LGTM. Please squash down to one commit.

@snikulov
Copy link
Member Author

@bradking Done.
@bagder Could you please review and merge?
Thank you.

@bagder bagder closed this in 2132708 Aug 25, 2015
jgsogo pushed a commit to jgsogo/curl that referenced this pull request Oct 19, 2015
@snikulov @jgsogo
cmake: added Windows SSL support
05c146e 
Closes curl#399
@snikulov snikulov deleted the cmake_windows_ssl branch January 11, 2019 10:46
@lock lock bot locked as resolved and limited conversation to collaborators Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snikulov @bradking