Update doc CURLOPT_SEEKDATA #4118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix variable name
bagder
reviewed
Jul 16, 2019
| @@ -39,7 +39,7 @@ HTTP, FTP, SFTP | |||
| .nf | |||
| static int seek_cb(void *userp, curl_off_t offset, int origin) | |||
| { | |||
| struct data *d = (struct data *)userp; | |||
| struct data *our_fd = (struct data *)userp; | |||
| lseek(our_fd, offset, origin); | |||
There was a problem hiding this comment.
This fixes one problem but this now instead passes in a struct data pointer to lseek() which also seems wrong.
How about we we instead change the lseek() call to become:
lseek(d->our_fd, offset, origin);
|
Thanks |
caraitto
pushed a commit
to caraitto/curl
that referenced
this pull request
Jul 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix variable name