Avoid reserved names in e?hiperfifo.c examples #4153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from upstream curl
Pull upstream master
Pull upstream master
Sync fork to original
Merge upstream master
bagder
approved these changes
Jul 25, 2019
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #4120 (comment) here is a simple set of fixed to a couple of the example programs that allows them to compile (at least on Linux), and avoids using reserved names.
As far as I can tell, these examples are not built by default (because they have non-universal external dependencies), so they have probably just slightly rotted.
_Unusedstarts with_and a capital letter, so it's reserved for the toolchain. Avoid that.(void)_Unused;don't make sense to me and don't compile. Fix that.(void)x;style to markxas unused, and avoid the whole issue. (Why can't C have C++'s common sense rule of just leaving the arguments unnamed?)Tested by building these manually on Linux x86_64.