Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid truncating DNS QTYPE to lower octet in doh_encode() #4381

Closed
wants to merge 1 commit into from
Closed

Avoid truncating DNS QTYPE to lower octet in doh_encode() #4381

wants to merge 1 commit into from

Conversation

niallor
Copy link

@niallor niallor commented Sep 19, 2019

DOH: avoid truncating DNS QTYPE to lower octet

IANA has registered DNS TYPE
codes beyond 255, but doh_encode() copies only the low 8 bits from argument
dnstype to the query buffer.

@bagder bagder closed this in 0d59add Sep 19, 2019
@bagder
Copy link
Member

bagder commented Sep 19, 2019

thanks!

@niallor niallor deleted the doh-type-fix branch September 19, 2019 21:50
@lock lock bot locked as resolved and limited conversation to collaborators Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@niallor @bagder