Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtls: fix narrowing conversion warnings #4398

Closed
wants to merge 1 commit into from

Conversation

MarcelRaad
Copy link
Member

Curl_timeleft returns timediff_t, which is 64 bits wide also on
32-bit systems since commit b1616da.

Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Where did you get these warnings and can we get such a build going in the CI somewhere?

@MarcelRaad
Copy link
Member Author

I got them with 32-bit MinGW. They used to be visible in one of my autobuilds, but unfortunately they're currently down because of problems with the mail server.

I'll look into adding such a build to AppVeyor!

Curl_timeleft returns `timediff_t`, which is 64 bits wide also on
32-bit systems since commit b1616da.

Closes curl#4398
@MarcelRaad MarcelRaad deleted the vtls_timeleft_warnings branch September 23, 2019 07:48
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Sep 24, 2019
With OpenSSL, WinSSL, and testing enabled so that it would have detected most of the warnings fixed in [0] and [1].

[0] curl#4398
[1] curl#4415

Closes
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Sep 24, 2019
With WinSSL and testing enabled so that it would have detected most of the warnings fixed in [0] and [1].

[0] curl#4398
[1] curl#4415

Closes
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Sep 24, 2019
With WinSSL and testing enabled so that it would have detected most of the warnings fixed in [0] and [1].

[0] curl#4398
[1] curl#4415

Closes
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Sep 27, 2019
With WinSSL and testing enabled so that it would have detected most of the warnings fixed in [0] and [1].

[0] curl#4398
[1] curl#4415

Closes
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Sep 27, 2019
With WinSSL and testing enabled so that it would have detected most of the warnings fixed in [0] and [1].

[0] curl#4398
[1] curl#4415

Closes
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Sep 30, 2019
With WinSSL and testing enabled so that it would have detected most of
the warnings fixed in [0] and [1].

[0] curl#4398
[1] curl#4415

Closes curl#4433
@lock lock bot locked as resolved and limited conversation to collaborators Dec 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants