travis: use go stable, (second try) #4403
Conversation
jay
force-pushed
the
bagder/travis-boringssl-go
branch
from
5ad50d9
to
52b264a
Compare
|
Is something else affecting the two boringssl builds? i don't see why this Lines 1872 to 1888 in 4a778f7 confused by (char *)"" maybe. i wonder if it would be confused even if const char *hostname. bad practice anyway so how about char empty[]=""; then later there if (!hostname) hostname = empty; |
|
Try it. And the check for '[' could use an |
Attempt to address this:
url.c: In function ‘Curl_connect’:
url.c:1883:13: error: offset outside bounds of constant string [-Werror]
hostname++;
^
|
That seems to have done it! |
Yeah but we're still lying to the compiler, bad practice... In other news support says gimme is not preinstalled on mac VMs so they would need how about this diff --git a/lib/url.c b/lib/url.c
index e4c4793..a6794a3 100644
--- a/lib/url.c
+++ b/lib/url.c
@@ -1869,12 +1869,10 @@ static CURLcode parseurlandfillconn(struct Curl_easy *data,
(void)curl_url_get(uh, CURLUPART_QUERY, &data->state.up.query, 0);
+ /* note file:// transfers may not have a hostname */
hostname = data->state.up.hostname;
- if(!hostname)
- /* this is for file:// transfers, get a dummy made */
- hostname = (char *)"";
- if(hostname[0] == '[') {
+ if(hostname && hostname[0] == '[') {
/* This looks like an IPv6 address literal. See if there is an address
scope. */
size_t hlen;
@@ -1888,7 +1886,7 @@ static CURLcode parseurlandfillconn(struct Curl_easy *data,
}
/* make sure the connect struct gets its own copy of the host name */
- conn->host.rawalloc = strdup(hostname);
+ conn->host.rawalloc = strdup(hostname ? hostname : "");
if(!conn->host.rawalloc)
return CURLE_OUT_OF_MEMORY;
conn->host.name = conn->host.rawalloc;comment probably unnecessary now since code speaks for it |
|
sure, that works for me! |
For now, yes. I think it would be valuable to add those builds to osx too though so it could be worth testing out that solution. But let's do that in a separate PR. |
Mac builds have been failing since 52db0b8 was added to use go stable in all builds. Based on the failures it looks like gimme is not available in Mac images? I've written support to find out but also I'd like to see if it's possible to limit getting go latest stable to just the boringssl builds.
Ref: #4361