connecache: fix multi-thread use of shared connection cache #4557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nah, still not quite there, segfaults in test 1541 |
bagder
force-pushed
the
bagder/shared-connection-race
branch
3 times, most recently
from
82e4147
to
94d3061
Compare
|
I've now run test 1541 in this branch in a loop in my own FreeBSD 12 VM. 100 iterations and it didn't crash once. I've done the same on my Linux and it didn't crash once. |
bagder
force-pushed
the
bagder/shared-connection-race
branch
from
9e48b05
to
e2b847a
Compare
bagder
force-pushed
the
bagder/shared-connection-race
branch
2 times, most recently
from
fb1db1a
to
308d5d8
Compare
|
I was able to reproduce this on mac and even though there's no valgrind on this platform, address sanitizer and more assert()s helped me this track down. Will polish and commit a fixup within shortly. Hopefully this was the same issue we saw on freebsd too. |
It could accidentally let the connection get used by more than one thread, leading to double-free and more. Reported-by: Christopher Reid Fixes #4544
bagder
force-pushed
the
bagder/shared-connection-race
branch
from
307c058
to
0d150e0
Compare
|
It seems to have fixed the race in 1541, but introduced a regression for 1700... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could accidentally let the connection get used by more than one
thread, leading to double-free and more.
Reported-by: Christopher Reid
Fixes #4544