Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl --upload-file "{file1,file2}" loops forever #4588

Closed
kdudka opened this issue Nov 12, 2019 · 4 comments
Closed

curl --upload-file "{file1,file2}" loops forever #4588

kdudka opened this issue Nov 12, 2019 · 4 comments
Assignees
@bagder
Labels
cmdline tool regression

Comments

@kdudka
Copy link
Contributor

kdudka commented Nov 12, 2019

The following command:

$ touch file1 && curl -T '{file1,file2}' sftp://localhost/tmp/ -u :

... lops forever with curl-7.67.0:

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (3) URL using bad/illegal format or missing URL
curl: (3) URL using bad/illegal format or missing URL
curl: (3) URL using bad/illegal format or missing URL
curl: (3) URL using bad/illegal format or missing URL
curl: (3) URL using bad/illegal format or missing URL
curl: (3) URL using bad/illegal format or missing URL
curl: (3) URL using bad/illegal format or missing URL
curl: (3) URL using bad/illegal format or missing URL
[...]

It seems to be caused by commit e59371a (PR #4438).

Originally reported at: https://bugzilla.redhat.com/1771025
@bagder bagder self-assigned this Nov 12, 2019
@bagder
Copy link
Member

bagder commented Nov 12, 2019

Ouch. I'm on it.

@bagder
Copy link
Member

bagder commented Nov 12, 2019

Turns out we don't have a single test using this feature! 😞

bagder added a commit that referenced this issue Nov 13, 2019
@bagder
curl: fix -T globbing
fdf4d68 
Regression from e59371a (7.67.0)

Added test 490, 491 and 492 to verify the functionality.

Reported-by: Kamil Dudka
Reported-by: Anderson Sasaki

Fixes #4588
Closes #
@bagder bagder mentioned this issue Nov 13, 2019
Closed
@klingtnet
Copy link

Can confirm this issue for curl 7.67.0 on Arch Linux.

Minimal working example:

$ curl --upload-file '{A,B}' httpbin.org/post

where A and B are some random files.

$ curl --version
curl 7.67.0 (x86_64-pc-linux-gnu) libcurl/7.67.0 OpenSSL/1.1.1d zlib/1.2.11 libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.2.0) libssh2/1.9.0 nghttp2/1.39.2
Release-Date: 2019-11-06
Protocols: dict file ftp ftps gopher http https imap imaps pop3 pop3s rtsp scp sftp smb smbs smtp smtps telnet tftp 
Features: AsynchDNS GSS-API HTTP2 HTTPS-proxy IDN IPv6 Kerberos Largefile libz NTLM NTLM_WB PSL SPNEGO SSL TLS-SRP UnixSockets

@bagder
Copy link
Member

bagder commented Nov 14, 2019

Sure, this bug is in 7.67.0 for all builds and distros.

@bagder bagder closed this as completed in 7a46aeb Nov 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bagder bagder

Labels
cmdline tool regression
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

curl: fix -T globbing curl/curl
3 participants
@bagder @kdudka @klingtnet