Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define CARES_STATICLIB for Windows builds when WITH_CARES=static. #4688

Closed
wants to merge 1 commit into from
Closed

Define CARES_STATICLIB for Windows builds when WITH_CARES=static. #4688

wants to merge 1 commit into from

Conversation

unlightable
Copy link

When libcurl is built with MODE=static, c-ares is forced into static linkage too.
That doesn't happen when MODE=dll so linker breaks over undefined symbols.

Define CARES_STATICLIB for Windows builds when WITH_CARES=static.
9e8b27b 
When libcurl is built with MODE=static, c-ares is forced into static linkage too.
That doesn't happen when MODE=dll so linker breaks over undefined symbols.
bagder
bagder approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems totally reasonable!

@jay jay added build Windows Windows-specific labels Dec 10, 2019
@jay jay closed this in 476a832 Dec 10, 2019
@jay
Copy link
Member

jay commented Dec 10, 2019

Thanks

@sthagen sthagen mentioned this pull request Dec 10, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
build Windows Windows-specific
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@unlightable @jay @bagder