Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

例子代码错误 #4751

Closed
kouzhudong opened this issue Dec 24, 2019 · 1 comment · Fixed by sthagen/curl-curl#28
Closed

例子代码错误 #4751

kouzhudong opened this issue Dec 24, 2019 · 1 comment · Fixed by sthagen/curl-curl#28
Labels
documentation

Comments

@kouzhudong
Copy link

在http-post.c中curl_global_cleanup();的调用在if之外。
在postinmemory.c中curl_global_cleanup();的调用在if之内。

代码矛盾，肯定有一个是错的。

在下认为postinmemory.c中curl_global_cleanup();的调用是错误的。
@jay jay closed this as completed in 68da0b8 Dec 24, 2019
@jay
Copy link
Member

jay commented Dec 24, 2019

In the future please make your report in English. I will attempt to translate. http-post example has curl_global_cleanup in a different position than postinmemory example. You think postinmemory example is wrong.

I agree because in postinmemory example curl_global_cleanup would not be called if curl_easy_init fails. I have made the change. Thanks.

@sthagen sthagen mentioned this issue Dec 24, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
documentation
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

examples/postinmemory.c: Call curl_global_cleanup always curl/curl
2 participants
@jay @kouzhudong