New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow RCPT TO command to fail for some recipients #4816
Conversation
Please look into fixing your code for the CI errors. |
Don't be alarmed by the red CI build(s), that's just due to flaky/bad environments and not because of any flaw in your PR. Ignore them. |
It would be nice if you now could squash all your commits into a single one (and force-push that) to improve the review experience. |
Folks, thanks for the early comments but this PR is not ready for review yet as I'm still dealing with the couple of things. Will send out for review once this is presentable. |
089704f
to
f76cd1e
Compare
8ab7934
to
1c1b7b9
Compare
dc7f0b0
to
5450c70
Compare
Addressed initial feedback, made a couple minor changes. Some checks are still failing but I'm assuming it's due to the flakiness (as @bagder mentioned). New and existing tests for SMTP seem to be passing. |
…n the documentation.
Thanks! |
This PR resolves #4792 adding a new option to control whether to allow
RCPT TO
command to fail for some recipients (and proceed with the remaining valid ones).In case when all recipients cause failures, curl will abort SMTP conversation and return the error received from to the last
RCPT TO
command.