Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS400 check dupstring enumeration at build time, not runtime #4822

Closed
wants to merge 7 commits into from
Closed

OS400 check dupstring enumeration at build time, not runtime #4822

wants to merge 7 commits into from

Conversation

jonrumsey
Copy link
Contributor

"*** WARNING: curl_easy_setopt_ccsid() should be reworked ***" appears at runtime on OS400 when using curl_easy_setopt_ccsid() because runtime checks in ccsidcurl.c did not account for conditional directives.

As discussed in pull request #4789, a better way to handle this would be to remove the conditional directives so that the enumeration indices don't change with compiler options, also remove the runtime check and replace with a build time check.

@jonrumsey
Build small string checking program
8ca366d 
Check that updates to the dupstring enums are reflected in packages/OS400/ccsidcurl.c
@jonrumsey
Revert "Build small string checking program"
ec61755 
This reverts commit 8ca366d.
@jonrumsey
Update urldata.h
5a4560f 
Remove conditional directives and add comment to indicate what additional steps are required for OS400.
@jonrumsey
Revert "Revert "Build small string checking program""
011075a 
This reverts commit ec61755.
@bagder
Copy link
Member

bagder commented Jan 15, 2020 

./urldata.h:1437:72: warning: Trailing whitespace (TRAILINGSPACE)
  * null terminated strings MUST be added to the enumeration immediately 
                                                                        ^
./urldata.h:1438:70: warning: Trailing whitespace (TRAILINGSPACE)
  * before STRING_LASTZEROTERMINATED, binary fields immediately before 
                                                                      ^
checksrc: 0 errors and 2 warnings
checksrc: 0 errors and 6 warnings suppressed

@jonrumsey
Update urldata.h
b36666f 
Remove extraneous  trailing spaces in comments
@bagder
Copy link
Member

bagder commented Jan 22, 2020

Thanks, can you squash this into a single commit and rebase it please? To make it easier to review and see what the ultimate change looks like.

@jonrumsey
Build small string checking program for OS400 and check that updates …
8343acc 
…to the dupstring enums are reflected in packages/OS400/ccsidcurl.c
@bagder bagder closed this in 4228700 Jan 27, 2020
@bagder
Copy link
Member

bagder commented Jan 27, 2020

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
@jonrumsey jonrumsey deleted the os400-chkstrings branch October 15, 2020 07:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonrumsey @bagder