Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ftp: remove superfluous checking for crlf in user or pwd #4887

Closed
wants to merge 2 commits into from
Closed

ftp: remove superfluous checking for crlf in user or pwd #4887

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 6, 2020

... as this is already done much earlier in the URL parser.

Also add test case 894 that verifies that pop3 with an encodedd CR in
the user name is rejected.

@bagder
ftp: remove superfluous checking for crlf in user or pwd
891cf4a 
... as this is already done much earlier in the URL parser.

Also add test case 894 that verifies that pop3 with an encodedd CR in
the user name is rejected.
@bagder bagder closed this in 950b53d Feb 7, 2020
bagder added a commit that referenced this pull request Feb 7, 2020
@bagder
ftp: remove the duplicated user/password struct fields
5ce7102 
Closes #4887
@bagder bagder deleted the bagder/username-with-cr branch February 7, 2020 07:19
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
FTP URL
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bagder