socks: make the connect phase non-blocking #4907
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
added a commit
that referenced
this pull request
Feb 11, 2020
Removes two entries from KNOWN_BUGS. Closes #4907
bagder
force-pushed
the
bagder/socks-nonblocking
branch
from
71d5047
to
bc7d461
Compare
Removes two entries from KNOWN_BUGS. Closes #4907
bagder
force-pushed
the
bagder/socks-nonblocking
branch
from
c54ae30
to
692cb46
Compare
bagder
added a commit
that referenced
this pull request
Mar 8, 2020
1. The socks4 state machine was broken in the host resolving phase 2. The code now insists on IPv4-only when using SOCKS4 as the protocol only supports that. Regression from #4907 and 4a4b63d, shipped in 7.69.0 Reported-by: amishmm on github Bug: #5053 (comment)
bagder
added a commit
that referenced
this pull request
Mar 8, 2020
1. The socks4 state machine was broken in the host resolving phase 2. The code now insists on IPv4-only when using SOCKS4 as the protocol only supports that. Regression from #4907 and 4a4b63d, shipped in 7.69.0 Reported-by: amishmm on github Bug: #5053 (comment) Closes #5061
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes two entries from KNOWN_BUGS.