md5: Added mbedtls implementation #4980
Conversation
lib/md5.c
Outdated
| (void) mbedtls_md5_update_ret(ctx, data, length); | ||
| } | ||
|
|
||
| static void MD5_Final(unsigned char digest[16], MD5_CTX *ctx) |
There was a problem hiding this comment.
I get why you did this (because mbedtls does I assume) but I think the fixed size array style is misleading, if you sizeof(digest) it's going to be the size of the pointer not of the array. If we are passing *input I think it should just be passed as that.
There was a problem hiding this comment.
NEvermind it looks like that's the current convention, I'd stick with it.
There was a problem hiding this comment.
Unfortunately it's not related to mbedtls, the other (well... GnuTLS based) functions use this style and you'll also note that the SHA256 code does this too (I'm guessing as the MD5 code was used as a template).
I'm personally not a fan if it because of it for the reason you gave ;-) As such you'll note I've used pointer notation in PR #4956 for my new SHA256 functions and corrected the existing function to match.
captain-caveman2k
force-pushed
the
mbedtls_md5
branch
2 times, most recently
from
90572db
to
48e62c7
Compare
captain-caveman2k
force-pushed
the
mbedtls_md5
branch
from
48e62c7
to
7ab6571
Compare
No description provided.