configure: fix use of -isystem for system headers #5060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, the c89 thing introduces a bunch of compiler warnings... |
|
Most of them totally crazy too. 😞 I'll remove that and see if -isystem will be enough to fix for example the brotli header complaints. |
As all the -I uses in CFLAGS at that point are for system headers and third party libraries this helps us remove/ignore warnings on those!
bagder
force-pushed
the
bagder/configure-compiler
branch
from
48e8aee
to
39a5784
Compare
bagder
changed the title
|
To play safe, I will merge this after 7.69.1 - since it does work-around the recent header warnings we've seen in 3rd party libs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.