Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select: move duplicate select preparation code into Curl_select #5078

Closed
wants to merge 3 commits into from
Closed

select: move duplicate select preparation code into Curl_select #5078

wants to merge 3 commits into from

Conversation

mback2k
Copy link
Member

@mback2k mback2k commented Mar 11, 2020

This introduces a re-used wrapper around select() to aid in Windows compatibility and timeout struct setup/preparation.

@mback2k mback2k marked this pull request as ready for review March 11, 2020 16:28
@mback2k mback2k requested a review from bagder March 11, 2020 16:28
@mback2k mback2k self-assigned this Mar 11, 2020
@mback2k
Copy link
Member Author

mback2k commented Mar 11, 2020

Once this PR has landed my plan is to do a follow-up and tidy-up the int vs. time_t for timeouts.

@mback2k
Copy link
Member Author

mback2k commented Mar 14, 2020

Also the new Curl_select function could be used here then:

curl/lib/vtls/gskit.c

Line 547 in 0845ecb

i = select(n + 1, &fds_read, &fds_write, NULL, &tv);

@mback2k
Copy link
Member Author

mback2k commented Mar 15, 2020

@bagder please take a look at my approach and approve the changes if you accept them.

@mback2k mback2k closed this in c52b342 Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

@MarcelRaad MarcelRaad MarcelRaad approved these changes

Assignees

@mback2k mback2k

Labels
tidy-up
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mback2k @bagder @MarcelRaad