Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gskit: use our internal select wrapper for portability #5106

Closed
wants to merge 1 commit into from
Closed

gskit: use our internal select wrapper for portability #5106

wants to merge 1 commit into from

Conversation

mback2k
Copy link
Member

@mback2k mback2k commented Mar 15, 2020

Follow up to c52b342

@mback2k mback2k self-assigned this Mar 15, 2020
@mback2k mback2k requested a review from bagder March 15, 2020 11:57
bagder
bagder approved these changes Mar 15, 2020
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gskit changes are very fragile as we have nobody around who uses or builds this on a regular basis, but yes the change looks innocuous enough...

@mback2k mback2k closed this in 083603c Mar 15, 2020
@mback2k mback2k mentioned this pull request Mar 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees

@mback2k mback2k

Labels
tidy-up
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mback2k @bagder