Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: nghttp2 1.12.0 required #5140

Closed
wants to merge 1 commit into from
Closed

doc: nghttp2 1.12.0 required #5140

wants to merge 1 commit into from

Conversation

cnotin
Copy link
Contributor

@cnotin cnotin commented Mar 23, 2020

since nghttp2_session_set_local_window_size is needed

Proof in configure.ac:

curl/configure.ac

Lines 3388 to 3390 in 27ea8fc

# use nghttp2_session_set_local_window_size to require nghttp2
# >= 1.12.0
AC_CHECK_LIB(nghttp2, nghttp2_session_set_local_window_size,

I found it when trying to build with ./configure --with-nghttp2 while having libnghttp2 1.7.1-1

@cnotin
nghttp2 1.12.0 required
2caee77 
since nghttp2_session_set_local_window_size is needed
@cnotin cnotin changed the title nghttp2 1.12.0 required doc: nghttp2 1.12.0 required Mar 23, 2020
@bagder
Copy link
Member

bagder commented Mar 23, 2020

Thanks!

@bagder bagder closed this in 12144fd Mar 23, 2020
@cnotin cnotin deleted the patch-1 branch March 23, 2020 21:24
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cnotin @bagder