Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test1248: use %NOLISTENPORT instead of a port of a non-running server #5318

Closed
wants to merge 2 commits into from
Closed

test1248: use %NOLISTENPORT instead of a port of a non-running server #5318

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented May 1, 2020

Otherwise the test fails when run stand-alone!

@bagder bagder added the tests label May 1, 2020
emilengler
emilengler approved these changes May 2, 2020
View reviewed changes
Copy link
Contributor

@emilengler emilengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@bagder
Copy link
Member Author

bagder commented May 2, 2020

I wrote a shell script that runs each available test one by one. It takes forever but it finds these problems pretty well...

@bagder bagder closed this in f9c6feb May 2, 2020
@bagder bagder deleted the bagder/nolisten branch May 10, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilengler emilengler emilengler approved these changes

Assignees
No one assigned
Labels
tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bagder @emilengler