Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: reject too long input when parsing credentials #5383

Closed
wants to merge 1 commit into from
Closed

url: reject too long input when parsing credentials #5383

wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented May 12, 2020

Since input passed to libcurl with CURLOPT_USERPWD and
CURLOPT_PROXYUSERPWD circumvents the regular string length check we have
in Curl_setstropt(), the input length limit is enforced in
Curl_parse_login_details too, separately.

@bagder
url: reject too long input when parsing credentials
73d5d22 
Since input passed to libcurl with CURLOPT_USERPWD and
CURLOPT_PROXYUSERPWD circumvents the regular string length check we have
in Curl_setstropt(), the input length limit is enforced in
Curl_parse_login_details too, separately.
@bagder bagder added the tidy-up label May 12, 2020
@bagder bagder closed this in e1f3f3a May 13, 2020
@bagder bagder deleted the bagder/too-login-creds branch May 13, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tidy-up
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bagder