New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timeouts: move ms timeouts to timediff_t from int and long #5490
Conversation
This looks like a pretty wide overlap with #5479 ... |
I propose I merge that first and then you can rebase this to remove the duplicates and we can focus on what isn't overlaps! |
I am fine with that. Thanks! |
Now that all functions in select.[ch] take timediff_t instead of the limited time_t or int, we can remove type conversions and related preprocessor checks to silence compiler warnings. Based upon curl#5262 Related to curl#5479 Supersedes curl#5214, curl#5220 and curl#5221 Follow up to curl#5343 Closes curl#5490
Remove obsolete type conversions to time_t or int: Now that all functions in select.[ch] take timediff_t instead of the limited time_t or int, we can remove type conversions and related preprocessor checks to silence compiler warnings. Based upon curl#5262 Supersedes curl#5214, curl#5220 and curl#5221 Follow up to curl#5343 and curl#5479 Closes curl#5490
@bagder please take another look. I updated this PR to include |
Now that all functions in select.[ch] take timediff_t instead of the limited time_t or int, we can remove type conversions and related preprocessor checks to silence compiler warnings. Based upon curl#5262 Supersedes curl#5214, curl#5220 and curl#5221 Follow up to curl#5343 and curl#5479 Closes curl#5490
Now that all functions in select.[ch] take timediff_t instead of the limited time_t or int, we can remove type conversions and related preprocessor checks to silence compiler warnings. Based upon curl#5262 Supersedes curl#5214, curl#5220 and curl#5221 Follow up to curl#5343 and curl#5479 Closes curl#5490
Now that all functions in select.[ch] take timediff_t instead of the limited int or long, we can remove type conversions and related preprocessor checks to silence compiler warnings. Avoiding conversions from time_t was already done in 842f73d. Based upon curl#5262 Supersedes curl#5214, curl#5220 and curl#5221 Follow up to curl#5343 and curl#5479 Closes curl#5490
Merged now, because except 1 unrelated Windows build all CIs were green, including the c-ares builds. |
Now that all functions in select.[ch] take timediff_t instead
of the limited time_t or int, we can remove type conversions
and related preprocessor checks to silence compiler warnings.