openssl: set FLAG_TRUSTED_FIRST unconditionally #5530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some systems, openssl 1.0 is still the default, but it has been patched to contain all the recent security fixes. As a result of this patching, it is possible for macro X509_V_FLAG_NO_ALT_CHAINS to be defined, while the previous behavior of openssl to not look at trusted chains first, remains. Fix it: ensure X509_V_FLAG_TRUSTED_FIRST is always set, do not try to probe for the behavior of openssl based on the existence ofmacros.
bagder
approved these changes
Jun 6, 2020
|
Thanks! |
|
Too fast did you investigate his claim? I was the one who set it not to use trusted first when alt chains was in effect. @mattcaswell wrote "It makes no sense to combine the trusted first and alt chains strategies. With trusted first we have already checked all of the possible chains by the time we get to the end of the peer provided list - so there is no point in then popping certs off the top of our chain and checking the trusted store again." Ref: https://curl.haxx.se/mail/lib-2020-06/0001.html |
So, no, it wasn't too fast. But I'm open for alternative takes. Not sure spending a lot of brain-cells on old OpenSSL versions is worth it though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems, openssl 1.0 is still the default, but it has been patched to
contain all the recent security fixes. As a result of this patching, it is
possible for macro X509_V_FLAG_NO_ALT_CHAINS to be defined, while the previous
behavior of openssl to not look at trusted chains first, remains.
Problem is that curl will fail to verify websites stills serving an expired, intermediate certificate, which happened quite a few times recently: https://www.agwa.name/blog/post/fixing_the_addtrust_root_expiration
Fix it: ensure X509_V_FLAG_TRUSTED_FIRST is always set, do not try to probe for
the behavior of openssl based on the existence of this macro.