Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODE_REVIEW.md: how to do code reviews in curl #5555

Closed
wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Jun 11, 2020

When this document gets merged, it should satisfy the final criteria for curl to become Gold Level complaint CII Best Practices.

See https://bestpractices.coreinfrastructure.org/en/projects/63

Copy link
Member

@danielgustafsson danielgustafsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on tackling this!

docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Show resolved Hide resolved
docs/CODE_REVIEW.md Show resolved Hide resolved
docs/CODE_REVIEW.md Show resolved Hide resolved
docs/CODE_REVIEW.md Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
@bagder
Copy link
Member Author

bagder commented Jun 11, 2020

Take two - with @danielgustafsson's comments taken care of and merged in.

docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
Copy link

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little nits :)

docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/Makefile.am Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Show resolved Hide resolved
docs/CODE_REVIEW.md Show resolved Hide resolved
bagder added a commit that referenced this pull request Jun 12, 2020
Assisted-by: Daniel Gustafsson
Assisted-by: Rich Salz
Assisted-by: Hugo van Kemenade

Closes #5555
@bagder
Copy link
Member Author

bagder commented Jun 12, 2020

Take three, squashed into a single commit again for easier further review commenting. If any.

Assisted-by: Daniel Gustafsson
Assisted-by: Rich Salz
Assisted-by: Hugo van Kemenade
Assisted-by: James Fuller
Assisted-by: Marc Hörsken
Assisted-by: Jay Satiro

Closes #5555
@bagder
Copy link
Member Author

bagder commented Jun 12, 2020

Take four was squashed and force-pushed.

@bagder bagder closed this in 350a99b Jun 13, 2020
@bagder
Copy link
Member Author

bagder commented Jun 13, 2020

Thank you everyone for awesome feedback and help with this. If you find more things to fix, let's do them as regular pull-requests from now!

@bagder bagder deleted the bagder/code-review branch June 13, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

7 participants