Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doh: remove redundant cast #5704

Closed
wants to merge 1 commit into from
Closed

doh: remove redundant cast #5704

wants to merge 1 commit into from

Conversation

MarcelRaad
Copy link
Member

No description provided.

emilengler
emilengler approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@emilengler emilengler left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. However while looking at this file I am curious if addr should really be a sockaddr_in because of IPv6

@MarcelRaad MarcelRaad deleted the remove_redundant_cast branch July 21, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

@emilengler emilengler emilengler approved these changes

@sterchelen sterchelen sterchelen approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MarcelRaad @bagder @emilengler @sterchelen