openssl: fix build with LibreSSL < 2.9.1 #5757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SSL_CTX_add0_chain_cert` and `SSL_CTX_clear_chain_certs` were introduced in LibreSSL 2.9.1 [0]. [0] libressl/openbsd@0db809e Closes
bagder
reviewed
Aug 1, 2020
| #if (OPENSSL_VERSION_NUMBER >= 0x1000200fL) /* 1.0.2 or later */ | ||
| #if (OPENSSL_VERSION_NUMBER >= 0x1000200fL) && /* OpenSSL 1.0.2 or later */ \ | ||
| !(defined(LIBRESSL_VERSION_NUMBER) && \ | ||
| (LIBRESSL_VERSION_NUMBER < 0x2090100fL)) /* LibreSSL 2.9.1 or later */ |
There was a problem hiding this comment.
if its this version or later shouldn't the condition then be: LIBRESSL_VERSION_NUMBER >= 0x2090100fL ?
There was a problem hiding this comment.
Ah no, I didn't really spot the negation in front of that second half... It just surprised me, but there's noting wrong there I think.
There was a problem hiding this comment.
Yes, I tried to match the style of the other conditions in this file and had to look at them twice too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSL_CTX_add0_chain_certandSSL_CTX_clear_chain_certswereintroduced in LibreSSL 2.9.1 [0].
This fixes the build with LibreSSL 2.8.0, as shipped with openSUSE Leap 15.2.
[0] libressl/openbsd@0db809e