select.h: make socket validation macros test for INVALID_SOCKET #5760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay
reviewed
Aug 2, 2020
MarcelRaad
approved these changes
Aug 2, 2020
bagder
approved these changes
Aug 2, 2020
With Winsock the valid range is [0..INVALID_SOCKET-1] according to https://docs.microsoft.com/en-us/windows/win32/winsock/socket-data-type-2 Reviewed-by: Jay Satiro Reviewed-by: Marcel Raad Reviewed-by: Daniel Stenberg Closes curl#5760
mback2k
force-pushed
the
win32-invalid-socket
branch
from
b182222
to
b5b7710
Compare
|
@jay please take another look, I slightly updated the comment according to your feedback. |
|
Looks fine Marc. IMO the code should speak for itself when it can and does here. If you think the extra sentence on winsock is necessary that's fine I'm not against it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Winsock the valid range is between 0 and INVALID_SOCKET-1 according to:
https://docs.microsoft.com/en-us/windows/win32/winsock/socket-data-type-2