Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl: consider ALERT_CERTIFICATE_EXPIRED a failed verification #5934

Closed
wants to merge 1 commit into from
Closed

openssl: consider ALERT_CERTIFICATE_EXPIRED a failed verification #5934

wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Sep 7, 2020

If the error reason from the lib is
SSL_R_SSLV3_ALERT_CERTIFICATE_EXPIRED, libcurl will return
CURLE_PEER_FAILED_VERIFICATION and not CURLE_SSL_CONNECT_ERROR.

This unifies the libcurl return code and makes libressl run test 313
(CRL testing) fine.

@bagder
openssl: consider ALERT_CERTIFICATE_EXPIRED a failed verification
b4d374d 
If the error reason from the lib is
SSL_R_SSLV3_ALERT_CERTIFICATE_EXPIRED, libcurl will return
CURLE_PEER_FAILED_VERIFICATION and not CURLE_SSL_CONNECT_ERROR.

This unifies the libcurl return code and makes libressl run test 313
(CRL testing) fine.
@bagder bagder added the TLS label Sep 7, 2020
@bagder bagder mentioned this pull request Sep 7, 2020
Closed
@bagder bagder closed this in 6d946ad Sep 7, 2020
@bagder bagder deleted the bagder/openssl-cert-expired-failed branch September 7, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
TLS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bagder