refactor: Remove 9 year old comment in memdebug.c #5973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilengler
added a commit
to emilengler/curl
that referenced
this pull request
Sep 17, 2020
The comment described a way how an ancient libcurl version handled memory. 9 years later this has no value to be in there. If people need to know about it they can have a look at VCS logs. Closes curl#5973
emilengler
force-pushed
the
2020-09-refactor-memdebug-comment
branch
from
16693c6
to
93bd41c
Compare
|
I think you should consider removing the entire memfill functionality if you remove the backstory/docs for it. That custom memory fill thing has lost its purpose. valgrind and ASAN are superior tools to catch memory issues. |
|
I will try to work on this until Saturday. I am currently a bit busy |
emilengler
added a commit
to emilengler/curl
that referenced
this pull request
Sep 22, 2020
The used to be away how an ancient libcurl version handled memory. 9 years later this has no value to be in there. If people need to know about it they can have a look at VCS logs. Closes curl#5973
emilengler
force-pushed
the
2020-09-refactor-memdebug-comment
branch
from
93bd41c
to
bcc3fe9
Compare
|
Found some time actually! This is ready for merge I think |
|
You need to remove the use of those macros too: |
Sure... but my cc haven't reported a single error on that patch 😟 |
|
Then you must've forgot to build it debug-enabled - as you can see in the CI... |
The used to be away how an ancient libcurl version handled memory. 9 years later this has no value to be in there. If people need to know about it they can have a look at VCS logs. Closes curl#5973
emilengler
force-pushed
the
2020-09-refactor-memdebug-comment
branch
from
bcc3fe9
to
97f3657
Compare
|
Thanks! (I edited the commit message somewhat) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment described a way how an ancient libcurl version handled
memory. 9 years later this has no value to be in there. If people need
to know about it they can have a look at VCS logs.