make pingpong's sendf() use dynbuf #6004
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By having
Curl_pp_vsendf
use a dynbuf for the send buffer, we avoid frequent malloc/realloc/free series. Test case 100 (FTP dir list PASV) does 7 fewer memory allocation calls after this in my test setup (132 => 125), curl 7.72.0 needed 140 calls for this.Test case 103 makes 9 less now (130). Down from 149 in 7.72.0.
This PR adds
Curl_dyn_vaddf
to the dynbuf API to make this possible.