Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTP uploading not reporting CURLE_REMOTE_DISK_FULL #6016

Closed
duncanwilcox opened this issue Sep 25, 2020 · 2 comments
Closed

FTP uploading not reporting CURLE_REMOTE_DISK_FULL #6016

duncanwilcox opened this issue Sep 25, 2020 · 2 comments
Assignees
@bagder
Labels
FTP

Comments

@duncanwilcox
Copy link

I did this

I used libcurl to upload a file to an FTP server, unfortunately I don't know what server it is. The server had exhausted the disk quota and after the STOR command the server returned a 552 error, which is appears to have been standardizes as meaning "disk full". Searching for "ftp 552" suggests it is widely supported.

Another FTP client (Transmit) reports the following:
2: Cmd: STOR test.mp4
2: 150: Opening BINARY mode data connection for test.mp4
2: Lost data connection to remote host after 458752 bytes had been sent: Broken pipe.
2: 552: Transfer aborted. Disk quota exceeded
2: STOR: notice: quota reached: used 245791.84 of 245760.00 upload Kb
2: STOR: notice: quota reached: 'test.mp4' removed

I thought this error might have been an interpretation on the client side so I used wireshark and actually saw the server responding 552:

Response: 552 STOR: notice: quota reached: 'test.mp4' removed

I expected the following

I expected libcurl to return CURLE_REMOTE_DISK_FULL, instead libcurl reports CURLE_PARTIAL_FILE, which is not incorrect but is less specific, particularly when it comes to offering actionable information to the user.

curl/libcurl version

We build libcurl ourselves, 7.72.0

operating system

macOS 10.15.6
@bagder bagder added the FTP label Sep 25, 2020
bagder added a commit that referenced this issue Sep 25, 2020
@bagder
ftp: make a 552 response return CURLE_REMOTE_DISK_FULL
6eb9abd 
Added test 348 to verify. Added a 'STOR' command to the test FTP
server to enable test 348. Documented the command in FILEFORMAT.md

Reported-by: Duncan Wilcox
Fixes #6016
@bagder bagder mentioned this issue Sep 25, 2020
Closed
@bagder
Copy link
Member

bagder commented Sep 25, 2020

So, #6017 is pretty much what you would expect then?

@bagder bagder self-assigned this Sep 25, 2020
@duncanwilcox
Copy link
Author

Wow didn't expect this so soon. Yes that looks great!

@bagder bagder closed this as completed in 4a4c724 Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagder bagder

Labels
FTP
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ftp: make a 552 response return CURLE_REMOTE_DISK_FULL curl/curl
2 participants
@bagder @duncanwilcox