Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS build fails when --disable-proxy #6025

Closed
jnavarrom opened this issue Sep 29, 2020 · 1 comment
Closed

iOS build fails when --disable-proxy #6025

jnavarrom opened this issue Sep 29, 2020 · 1 comment
Labels
build connecting & proxies

Comments

@jnavarrom
Copy link

jnavarrom commented Sep 29, 2020 •
edited

I did this

Updated from curl 7.51.0 to 7.72.0. Tried building for iOS (or simulator arch x86_64):

./configure --host=aarch64-apple-darwin --enable-static --disable-shared --with-secure-transport --with-zlib --disable-manual --disable-ftp --disable-file --disable-ldap --disable-ldaps --disable-rtsp --disable-proxy --disable-dict --disable-telnet --disable-tftp --disable-pop3 --disable-imap --disable-smtp --disable-gopher --disable-sspi --enable-ipv6 --disable-smb
make

vtls/sectransp.c:1157:7: warning: 'CFURLCreateDataAndPropertiesFromResource' is deprecated: first deprecated in iOS 7.0 - For resource data, use the CFReadStream API. For file resource
      properties, use CFURLCopyResourcePropertiesForKeys. [-Wdeprecated-declarations]
      CFURLCreateDataAndPropertiesFromResource(NULL,
      ^
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.0.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFURLAccess.h:52:9: note: 
      'CFURLCreateDataAndPropertiesFromResource' has been explicitly marked deprecated here
Boolean CFURLCreateDataAndPropertiesFromResource(CFAllocatorRef alloc, CFURLRef url, CFDataRef *resourceData, CFDictionaryRef *properties, CFArrayRef desiredProperties, SInt32 *errorCo...
        ^
vtls/sectransp.c:1402:56: error: no member named 'http_proxy' in 'struct connectdata'
  const char * const hostname = SSL_IS_PROXY() ? conn->http_proxy.host.name :
                                                 ~~~~  ^
vtls/sectransp.c:2382:56: error: no member named 'http_proxy' in 'struct connectdata'
  const char * const hostname = SSL_IS_PROXY() ? conn->http_proxy.host.name :
                                                 ~~~~  ^

I expected the following

Successful build.

curl/libcurl version

Compilation works on 7.70.0 and fails on 7.72.0 and 7.71.0

operating system

build host: macOS 10.15.6 with Xcode 12
iOS target: -miphoneos-version-min=10.0

Using curl 7.70.0 compilation works but using curl 7.71.0 compilation fails. So, I think the issue could be introduced #5466 (but not sure)
@bagder
Copy link
Member

bagder commented Sep 29, 2020

The Secure Transport related code seems to not have gotten the necessary updates in that change...

bagder added a commit that referenced this issue Sep 30, 2020
@bagder
sectransp: make it build with --disable-proxy
ab93154 
Follow-up from #5466 and f3d501d
Reported-by: Javier Navarro
Fixes #6025
@bagder bagder mentioned this issue Sep 30, 2020
Closed
@bagder bagder closed this as completed in b312e32 Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build connecting & proxies
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sectransp: make it build with --disable-proxy curl/curl
2 participants
@bagder @jnavarrom