ldap: reduce the amount of #ifdefs needed #6035
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
force-pushed
the
bagder/ldap-ifdefs
branch
from
5be8f49
to
60b8458
Compare
emilengler
reviewed
Oct 2, 2020
| @@ -259,6 +259,13 @@ static int ldap_win_bind(struct connectdata *conn, LDAP *server, | |||
| } | |||
| #endif /* #if defined(USE_WIN32_LDAP) */ | |||
|
|
|||
| #if defined(USE_WIN32_LDAP) | |||
| #define FREE_ON_WINLDAP(x) curlx_unicodefree(x) | |||
There was a problem hiding this comment.
Shouldn't the curlx_unicodefree((c)) into two brackets like it is in other places
There was a problem hiding this comment.
("brackets" are usually these: [] - I don't think you meant those)
I don't understand. Why do we need more parentheses?
There was a problem hiding this comment.
I mean these () brackets. They are being used in other macros in the code as well. See Curl_safefree()
|
The brackets elsewhere have a functional effect. They're there to prevent
issues with operator precedence in case the macro is called with an expression
instead of a bare identifier. In this context they would accomplish nothing.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.