Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rewording #865

Closed
wants to merge 1 commit into from
Closed

Fix rewording #865

wants to merge 1 commit into from

Conversation

m6w6
Copy link
Contributor

@m6w6 m6w6 commented Jun 7, 2016

Seems like a phrase was about to be replaced with another one, but only the addition made it in, not the removal.

Seems like a phrase was about to be replaced with another one, but only the addition made it in, not the removal.
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @bagder, @TheCount and @yangtse to be potential reviewers

@jay
Copy link
Member

jay commented Jun 7, 2016

I agree with what you're trying to do here but it is still not technically correct. The integer doesn't point to the number. It would probably be better understood if we were colloquial like 'running_handles receives the number of running easy handles' or something simple like that.

@jay jay closed this in 9295205 Jun 9, 2016
@jay
Copy link
Member

jay commented Jun 9, 2016

Thanks, it landed as: "At return, running_handles points to the number of running easy handles within the multi handle."

@m6w6 m6w6 deleted the patch-4 branch June 9, 2016 09:36
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants