Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP/2 uploads larger than 2^64 bytes aren't reliable #996

Closed
bagder opened this issue Sep 6, 2016 · 2 comments
Closed

HTTP/2 uploads larger than 2^64 bytes aren't reliable #996

bagder opened this issue Sep 6, 2016 · 2 comments
Labels
feature-window A merge of this requires an open feature window HTTP/2

Comments

@bagder
Copy link
Member

bagder commented Sep 6, 2016

I did this

Send an upload to a server using HTTP/2 without the size set before-hand. (If the size is set, it is limited to 64bit.) due to the logic that still decreases the "upload left" counter even when the size is unknown, it may reach zero accidentally after 2^64 bytes have been transferred even if the transfer hasn't actually ended.

I expected the following

curl should allow the upload stream to go on forever.

curl/libcurl version

all

operating system

all

Note: I have a patch in progress for this already, but I'm holding it off until after the pending release to give it more time to mature.
@bagder bagder added HTTP/2 feature-window A merge of this requires an open feature window labels Sep 6, 2016
@jay
Copy link
Member

jay commented Sep 6, 2016

I'm sure you're technically correct but are you saying there's a use case for over 16 exabytes? When I've touched http2.c I've never accounted for that...

@bagder
Copy link
Member Author

bagder commented Sep 6, 2016

Maybe, maybe not. It just struck me that the solution I went with has this limitation and it is easy to fix so I figured it is still worth it. I can imagine use cases where you for example stream video or something in a virtually never-ending stream.

@bagder bagder closed this as completed in 85033bc Sep 9, 2016
@lock lock bot locked as resolved and limited conversation to collaborators May 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-window A merge of this requires an open feature window HTTP/2
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bagder @jay