diff -u3 -H -B -w -r CVS-latest/lib/connect.c lib/connect.c --- CVS-latest/lib/connect.c Tue Mar 09 23:52:50 2004 +++ lib/connect.c Thu Mar 11 13:36:06 2004 @@ -417,6 +417,7 @@ /* This wasn't a successful connect */ return FALSE; #else + (void)sockfd; return TRUE; #endif } @@ -571,7 +572,7 @@ */ for (ai = remotehost->addr; ai; ai = ai->ai_next, aliasindex++) { sockfd = socket(ai->ai_family, ai->ai_socktype, ai->ai_protocol); - if (sockfd < 0) + if (sockfd == CURL_SOCKET_BAD) continue; #else /* @@ -681,7 +682,7 @@ } before = after; } - if (sockfd < 0) { + if (sockfd == CURL_SOCKET_BAD) { /* no good connect was made */ *sockconn = -1; failf(data, "Connect failed"); diff -u3 -H -B -w -r CVS-latest/lib/ftp.c lib/ftp.c --- CVS-latest/lib/ftp.c Wed Mar 10 17:20:33 2004 +++ lib/ftp.c Thu Mar 11 13:49:58 2004 @@ -166,7 +166,7 @@ default: /* we have received data here */ { - int s; + curl_socket_t s; size_t size = sizeof(struct sockaddr_in); struct sockaddr_in add; @@ -175,7 +175,7 @@ sclose(sock); /* close the first socket */ - if (-1 == s) { + if (CURL_SOCKET_BAD == s) { /* DIE! */ failf(data, "Error accept()ing server connect"); return CURLE_FTP_PORT_FAILED; @@ -766,7 +766,7 @@ #endif /* shut down the socket to inform the server we're done */ sclose(conn->sock[SECONDARYSOCKET]); - conn->sock[SECONDARYSOCKET] = -1; + conn->sock[SECONDARYSOCKET] = CURL_SOCKET_BAD; if(!ftp->no_transfer) { /* Let's see what the server says about the transfer we just performed, @@ -2379,10 +2379,10 @@ if(connected) retcode = Curl_ftp_nextconnect(conn); - if(retcode && (conn->sock[SECONDARYSOCKET] >= 0)) { + if(retcode && (conn->sock[SECONDARYSOCKET] != CURL_SOCKET_BAD)) { /* Failure detected, close the second socket if it was created already */ sclose(conn->sock[SECONDARYSOCKET]); - conn->sock[SECONDARYSOCKET] = -1; + conn->sock[SECONDARYSOCKET] = CURL_SOCKET_BAD; } if(ftp->no_transfer) diff -u3 -H -B -w -r CVS-latest/lib/multi.c lib/multi.c --- CVS-latest/lib/multi.c Wed Mar 10 17:01:48 2004 +++ lib/multi.c Thu Mar 11 13:08:13 2004 @@ -486,7 +486,7 @@ * possibly know if the connection is in a good shape or not now. */ easy->easy_conn->bits.close = TRUE; - if(-1 !=easy->easy_conn->sock[SECONDARYSOCKET]) { + if(CURL_SOCKET_BAD != easy->easy_conn->sock[SECONDARYSOCKET]) { /* if we failed anywhere, we must clean up the secondary socket if it was used */ sclose(easy->easy_conn->sock[SECONDARYSOCKET]); diff -u3 -H -B -w -r CVS-latest/lib/telnet.c lib/telnet.c --- CVS-latest/lib/telnet.c Tue Mar 09 23:52:50 2004 +++ lib/telnet.c Thu Mar 11 13:17:42 2004 @@ -1090,13 +1090,12 @@ WSANETWORKEVENTS events; HANDLE stdin_handle; HANDLE objs[2]; - DWORD waitret; - DWORD nread; + DWORD waitret, readfile_read; #else fd_set readfd; fd_set keepfd; - ssize_t nread; #endif + ssize_t nread; bool keepon = TRUE; char *buf = data->state.buffer; struct TELNET *tn; @@ -1203,10 +1202,11 @@ char *buffer = buf; if(!ReadFile(stdin_handle, buf, sizeof(data->state.buffer), - (LPDWORD)&nread, NULL)) { + &readfile_read, NULL)) { keepon = FALSE; break; } + nread = readfile_read; while(nread--) { outbuf[0] = *buffer++; diff -u3 -H -B -w -r CVS-latest/lib/timeval.c lib/timeval.c --- CVS-latest/lib/timeval.c Sun Jan 04 13:10:14 2004 +++ lib/timeval.c Thu Mar 11 13:12:38 2004 @@ -63,6 +63,7 @@ tp->tv_sec = Sec; tp->tv_usec = Usec; #endif /* WITHOUT_MM_LIB */ + (void)nothing; return 0; } #else /* WIN32 */ diff -u3 -H -B -w -r CVS-latest/lib/transfer.c lib/transfer.c --- CVS-latest/lib/transfer.c Wed Mar 10 17:20:33 2004 +++ lib/transfer.c Thu Mar 11 13:48:35 2004 @@ -1312,13 +1312,13 @@ if(conn->bits.getheader || !data->set.no_body) { FD_ZERO (&k->readfd); /* clear it */ - if(conn->sockfd != -1) { + if(conn->sockfd != CURL_SOCKET_BAD) { FD_SET (conn->sockfd, &k->readfd); /* read socket */ k->keepon |= KEEP_READ; } FD_ZERO (&k->writefd); /* clear it */ - if(conn->writesockfd != -1) { + if(conn->writesockfd != CURL_SOCKET_BAD) { /* HTTP 1.1 magic: Even if we require a 100-return code before uploading data, we might @@ -1408,7 +1408,7 @@ is different*/ Curl_readwrite_init(conn); - if((conn->sockfd == -1) && (conn->writesockfd == -1)) + if((conn->sockfd == CURL_SOCKET_BAD) && (conn->writesockfd == CURL_SOCKET_BAD)) /* nothing to read, nothing to write, we're already OK! */ return CURLE_OK; @@ -1953,11 +1953,11 @@ * possibly know if the connection is in a good shape or not now. */ conn->bits.close = TRUE; - if(-1 != conn->sock[SECONDARYSOCKET]) { + if(CURL_SOCKET_BAD != conn->sock[SECONDARYSOCKET]) { /* if we failed anywhere, we must clean up the secondary socket if it was used */ sclose(conn->sock[SECONDARYSOCKET]); - conn->sock[SECONDARYSOCKET]=-1; + conn->sock[SECONDARYSOCKET] = CURL_SOCKET_BAD; } } diff -u3 -H -B -w -r CVS-latest/lib/url.c lib/url.c --- CVS-latest/lib/url.c Wed Mar 10 17:01:49 2004 +++ lib/url.c Thu Mar 11 13:45:52 2004 @@ -1341,9 +1341,9 @@ Curl_SSL_Close(conn); /* close possibly still open sockets */ - if(-1 != conn->sock[SECONDARYSOCKET]) + if(CURL_SOCKET_BAD != conn->sock[SECONDARYSOCKET]) sclose(conn->sock[SECONDARYSOCKET]); - if(-1 != conn->sock[FIRSTSOCKET]) + if(CURL_SOCKET_BAD != conn->sock[FIRSTSOCKET]) sclose(conn->sock[FIRSTSOCKET]); Curl_safefree(conn->user); @@ -2022,8 +2022,8 @@ /* and we setup a few fields in case we end up actually using this struct */ conn->data = data; /* remember our daddy */ - conn->sock[FIRSTSOCKET] = -1; /* no file descriptor */ - conn->sock[SECONDARYSOCKET] = -1; /* no file descriptor */ + conn->sock[FIRSTSOCKET] = CURL_SOCKET_BAD; /* no file descriptor */ + conn->sock[SECONDARYSOCKET] = CURL_SOCKET_BAD; /* no file descriptor */ conn->connectindex = -1; /* no index */ conn->bits.httpproxy = (data->change.proxy && *data->change.proxy && (data->set.proxytype == CURLPROXY_HTTP))? @@ -3164,7 +3164,7 @@ conn->bytecount = 0; conn->headerbytecount = 0; - if(-1 == conn->sock[FIRSTSOCKET]) { + if(CURL_SOCKET_BAD == conn->sock[FIRSTSOCKET]) { bool connected; /* Connect only if not already connected! */