cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: curl-7.11.1 questions.

From: Maya Youlzari <MAYAY_at_Amdocs.com>
Date: Mon, 26 Apr 2004 13:15:57 +0300

Hi,

>
In reply to <http://curl.haxx.se/mail/lib-2004-04/0232.html>
> Hi,
> On Tue, 20 Apr 2004, Maya Youlzari wrote:
> >>> 1. In case of CURLE_PARTIAL_FILE error the QUIT command (before
> >>> disconnecting) always cause a function Curl_GetFTPResponse() to stuck until
> >>> time out occurred.
> >It sounds like a bug. When the transfer is prematurely aborted it is often due
> >to a bad network and then I think we should not send the final QUIT command.
> >Would you be able to provide a patch?
> I think I found the problem (at least it works in my tests) - the following lines are missing before "return CURLE_PARTIAL_FILE;" in file ftp.c (lines 745 and 755)
> /* shut down the socket to inform the server we're done */
> sclose(conn->sock[SECONDARYSOCKET]);
> conn->sock[SECONDARYSOCKET] = CURL_SOCKET_BAD;
> return CURLE_PARTIAL_FILE;
> Please approve and add it into the next patch.
> >>> Besides that, the QUIT command does not executed in usual disconnect but
> >>> only when some error occurred. Should the QUIT command be executed on every
> >>> disconnection?
> >The QUIT command is sent before the control connection is closed, unless a
> >problem with the connection was detected. It is not only sent when an error
> >has occurred, at least not in my versions and everyone elses' that run all the
> >ftp test cases fine.
> The QUIT command indeed sent before every disconnection. It was my misunderstanding.
> >>> 2. When using CURLOPT_INFILESIZE_LARGE option in case of upload, the
> >>> data->set.infilesize receives 107374182400 in spite of the original value is
> >>> 25.
> >And you are providing a value that is a curl_off_t variable? This looks like
> >you're providing a value that is not using the correct variable size.
> The problem indeed caused by incorrect variable size even when I am using curl_off_t type.
> The issue is that curl_off_t defined as off_t and on my SunOs off_t defined as long (32 bits) so I need to perform casting to (int64_t) which I don't want to do.
> On the other hand, in libcurl installation the curl_off_t detected as 64 bits variable.
> How you do it in libcurl installation, curl_off_t is still of type off_t? What cc flags or other definitions should be defined?
> Thanks.
>
>
> Maya
>
>

-------------------------------------------------------------------------------------

The information contained in this message is proprietary of Amdocs,

protected from disclosure, and may be privileged.

The information is intended to be conveyed only to the designated recipient(s)

of the message. If the reader of this message is not the intended recipient,

you are hereby notified that any dissemination, use, distribution or copying of

this communication is strictly prohibited and may be unlawful.

If you have received this communication in error, please notify us immediately

by replying to the message and deleting it from your computer.

Thank you.

-------------------------------------------------------------------------------------
Received on 2004-04-26