RE: FTP third party transfer (proxy) support.
Date: Wed, 9 Jun 2004 09:11:37 +0200 (CEST)
On Wed, 9 Jun 2004, Alexander Krasnostavsky wrote:
> > I'll check it out in a while. I'm a bit scared this option will clutter up
> > the code a lot...
> I know, but this change worth it. All the changes I made seem to be correct
> according to the code. For those who don't use this option it won't change
> anything. I have tried to build with all the "disable" option and only
> "http" was not working.
Thanks for the patch. I have these comments on your (generally fine) work:
1 - I don't want those ifdefs in the src-part. I think the curl tool should be
identical no matter what the libcurl is made to support. The app already
checks the curl_version_info() reply to see if the library supports stuff
such as GSS, NTLM and krb4. I think the check for HTTP-support should be
made in a similar run-time manner, not build-time.
2 - in lib/transfer.c you still include the header checks for
Content-Encoding, Last-Modified and Location when HTTP is disabled. Is
that on purpose or just an oversight?
> I have found that libcurl.def is missing in curllib.dsp. When I add it, the
> ".lib" file is created. Below are the missing lines:
Ah, thanks for this. I've now patched the generation of the file and it should
hopefully do right in tomorrow's snapshot!
-- Daniel Stenberg -- http://curl.haxx.se -- http://daniel.haxx.se Dedicated custom curl help for hire: http://haxx.se/curl.htmlReceived on 2004-06-09