Re: SSL patch
Date: Thu, 17 Jun 2004 13:01:31 +0200 (CEST)
On Thu, 17 Jun 2004, Gisle Vanem wrote:
>> Why can't we simply provide the text as CURLINFO_TEXT and the raw data as
>> CURLINFO_SSL_DATA_IN/OUT in two separate calls following each other?
> Sure, but I'd like a more compact trace. From the other "SSL cert error"
> If there where 2 calls, it wouldn't be totally clear that the "info" line
> belonged to the next "data" trace.
Right, I sympathize with this concern, but as the debug callback is defined to
only have one data pointer and one data type, I think it is better to adjust
to this now and then possibly introduce an enhanced debug callback
funcionality in the future that wouldn't split the info in two parts.
I don't want the app to be needing to split the data into a text part and a
> You mean a Curl_debugf() that takes either a block of data or a var-arg
Yes that's what I mean.
> I'd like something more versatile that could be printed both as a
> hex-dump *and* a text message. So ssluse.c would be
> Curl_debugf (data, CURLINFO_SSL_DATA_IN, buf, len,
> "SSLv%c, %s%s (%d)", ver, tls_rt_name, msg_name, msg_type);
> But this probably needs a change to (or a new) curl_debug_callback.
I think that would be a very good approach. A textual description for the
(possibly) binary data. That would require a new curl_debug_callback indeed.
(It would also nicely address the 3rd-party which-host output problem.)
-- Daniel Stenberg -- http://curl.haxx.se -- http://daniel.haxx.se Dedicated custom curl help for hire: http://haxx.se/curl.htmlReceived on 2004-06-17