cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: gknauf: curl/src Makefile.b32,1.3,1.4

From: Gisle Vanem <giva_at_bgnett.no>
Date: Wed, 14 Jul 2004 14:36:16 +0200

> +# 'BCCDIR' has to be set up to point to the base directory
> +# of the compiler, i.e. SET BCCDIR = c:\Borland\BCC55
> +# where c:\Borland\BCC55 is the compiler is installed

This shouldn't be needed if user setup the compiler correctly.
Since other compilers must also be setup, Borland shouldn't be
treated differently. I suggest this comment in the makefile.b32 files:

#
# Edit or create a <Borland-root>\bin\bcc32.cfg and add these
# lines:
# -I<Borland-root>\include
# -L<Borland-root>\lib;<Borland-root>\lib\PSDK
#

> +LDFLAGS = -lap
> +
> +# If you build without SSL support, remove "-DUSE_SSLEAY" from the line below.

This should be the default (i.e. no OpenSSL). Have you tried building OpenSSL with
Borland? Nearly impossible.

> +# DEFINES = -DLIBCURL_BIGENDIAN=0 -DNDEBUG -DWIN32 -DCONSOLE -DMBCS -DUSE_SSLEAY
> DEFINES = -DNDEBUG -DLIBCURL_BIGENDIAN=0 -DWIN32 -D_CONSOLE -D_MBCS

Why is the LIBCURL_BIGENDIAN needed?

> +INCDIRS = -I$(CURNTDIR);$(TOPDIR)/include;$(TOPDIR)/lib
> +LINKLIB = $(BCCDIR)/lib/psdk/ws2_32.lib

Should IMHO simply be
LINKLIB = cw32mt.lib winmm.lib ws2_32.lib

> +sys/utime.h: $(BCCDIR)\include\utime.h
> + @echo Fix missing header $@
> + @-mkdir sys
> + @$(CP) $** sys

Why not remove HAVE_SYS_UTIME_H and HAVE_UTIME for
__BORLANDC__ instead of this ugly hack?

--gv
Received on 2004-07-14