cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Bug in libcurl.m4?

From: Andreas Ntaflos <daff_at_dword.org>
Date: Tue, 9 May 2006 08:12:55 +0200

On Tuesday 09 May 2006 07:06, David Shaw wrote:
> On Tue, May 09, 2006 at 05:53:08AM +0200, Andreas Ntaflos wrote:
> > Here the LIBCURL variable get set to `-lcurl' and is never reset
> > again, thus making it's way into the resulting Makefile. Although I
> > don't really see how this happens since when libcurl is detected to
> > be unusable no calls to AC_SUBST(LIBCURL) are made, as far as I
> > could see.
>
> It's autoconf magic. It's enough that the AC_SUBST is seen at all,
> even though it isn't executed.

Black magic. Got it. :)

> Try the attached patch. It's safer than restoring the original
> values of LIBCURL since the idea of allowing a user to pass in
> LIBCURL is to try and find the library or add special link stuff. If
> that fails, then best to clear the variable altogether rather than
> try and link to something that already failed.

You're right. I didn't think it through (I was afraid to touch more than
absolutely needed to get the package to configure and build to the
end).

Thanks a lot for the patch, works very well now!

Andreas

-- 
Andreas "daff" Ntaflos 
daff AT dword DOT org
Vienna, Austria 
GPG Fingerprint: 	6234 2E8E 5C81 C6CB E5EC  7E65 397C E2A8 090C A9B4
GPG Public Key ID: 	090CA9B4
GPG Public Key:		http://daffit.meownz.info/publickey/andreas_ntaflos.asc
Received on 2006-05-09