cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re[2]: Bug in multi_runsingle

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Thu, 31 Aug 2006 14:51:15 +0200 (CEST)

On Thu, 31 Aug 2006, Dmitriy Sergeyev wrote:

>> I don't think the CURLM_CALL_MULTI_PERFORM assignment should be there like
>> that, and in fact I'm not sure it should be like that in the
>> CURLM_STATE_CONNECT case either. Can you try your test case again without
>> that line and see if it causes any noticable problem? If it must be there,
>> it should at least only be set for the STATE_DO case.
>
> If we omit this assignment than user program can call curl_multi_fdset
> which returns zero-sized read_fd_set. Is this behavior allowable?

Aha, right. That's why it is there. We need to make it start using the connect
socket first...

But yes, it _is_ allowable and can in fact happen in some very rare situations
on some platforms.

> Assigning CURLM_CALL_MULTI_PERFORM only for CURLM_STATE_DO looks work good
> and I haven't noticed any problems. Even when I've moved this assignment in
> CURLM_STATE_CONNECT.

Yes, let's leave the assignment there exactly like you did it. Thanks anyway
for testing. I'll commit this fix soon.

-- 
  Commercial curl and libcurl Technical Support: http://haxx.se/curl.html
Received on 2006-08-31