cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: keeping connection on multi_remove_handle for FTP

From: Armel Asselin <asselin.armel_at_wanadoo.fr>
Date: Thu, 28 Dec 2006 16:36:42 +0100

Hello,

>> now that I have a bit more experience with my own tool and the 'hard
>> cancellation' (coded with a CURLE_CANCELED error code passed to
>> curl_ftp_done, currently). this way seems rather acceptable, even
>> performance-wise. what I would like is then to progress first on this,
>> having something official and working. this thread is still interesting
>> because we viewed the main problems i think and we could keep in archive
>> for later improvements.
>>
>> so, from my point of view adding a simple test of the multi state wrt
>> COMPLETED and setting some error code would OK for that purpose (which
>> one? there is nothing very appealing in the list).
>
> Sure. I think Curl_done() needs a new argument named "premature" or
> something like that, so that protocols that care can get to know about it
> and act accordingly.
>
> Wouldn't that be good enough?
>
here is a first patch, I submit just for review to see if it's the kind of
patch that you expect (though it should work as is)

Armel

Received on 2006-12-28