cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: multi_runsingle referencing freed connection

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Sun, 18 Feb 2007 10:53:17 +0100 (CET)

On Sat, 17 Feb 2007, Jeff Pohlmeyer wrote:

> ====
> if (data->state.is_in_pipeline && check->bits.close) {
> /* Don't pick a connection that is going to be closed */
> infof(data, "Connection #%ld has been marked for close, can't
> reuse\n",
> check->connectindex);
> continue;
> }
> ====
>
> I don't don't understand the "is_in_pipeline" check here, if multi.c flagged
> the connection as bad, then it shouldn't get re-used, regardless if it is
> pipelined or not?

Yeah, that certainly seems like a correct remark. However, changing that check
to only if(check->bits.close) breaks test 530... I'm trying to figure out why.

-- 
  Commercial curl and libcurl Technical Support: http://haxx.se/curl.html
Received on 2007-02-18