Re: Patch to send arbitrary SFTP commands
Date: Thu, 29 Mar 2007 11:38:46 -0600
On Mar 29, 2007, at 3:01 AM, Daniel Stenberg wrote:
> No rename?
Oops, I missed that one last night. I'll add that today, thanks.
> Some remarks on the patch itself:
> o indentation and (no) TAB usage is not following libcurl standard
> o use less than 80 columns source code width
> o the quote errors could be set with failf() to provide a better
> error message
> o use memset() instead of bzero()
OK, I'll fix these.
> o use strnequal() instead of strncasecmp() - but are the commands
> meant to be case insensitive?
Yes. In OpenSSH's SFTP client they are, so they probably should be
here as well.
Received on 2007-03-29